Skip to content

ISSUE-11477 - fixed Swagger response for searchCriteria#15322

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
idziakjakub:fix-searchcriteria-swagger
Jun 7, 2018
Merged

ISSUE-11477 - fixed Swagger response for searchCriteria#15322
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
idziakjakub:fix-searchcriteria-swagger

Conversation

@idziakjakub
Copy link
Copy Markdown

Added zero index to array signifier in searchCriteria parameters builder

Description

This fix allows to generate correct response when user want to test method with some search criteria parameters in Swagger.

Fixed Issues (if relevant)

  1. Magento REST API Schema (Swagger) is not compatible with Search Criteria #11477: Magento REST API Schema (Swagger) is not compatible with Search Criteria

Manual testing scenarios

  1. Open Swagger
  2. In method "catalogProductRepositoryV1" fill in "Parameters" tab values for searchCriteria which use "filterGroups" key
  3. Click "Try it out!"
  4. Check if Response Code is 200

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @idziakjakub. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Event: WroCD Contribution day in Wro Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants